Mage-OS admin rebrand#36
Merged
Vinai merged 7 commits intomage-os:2.4-developfrom Oct 7, 2023
Merged
Conversation
Proof of concept -- For consideration and improvement
Contributor
Author
|
Note, I chose green for the main button color rather than Mage-OS orange because the contrast of white on green is far better than white on orange (5.5 vs 2.3). More readable and accessible. |
Contributor
Author
|
I fixed the coding standard warnings, and made some other small adjustments (better odd-row color, fixed gray hover background throughout; red flush-cache button). The one lingering standards warning is a false positive; it is correctly indented. |
Contributor
Author
|
I'll adjust the fly-out menu title gray color for better contrast. |
Contributor
Author
|
I've adjusted that header text color. Color contrast is now 7.68.
|
Vinai
approved these changes
Oct 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Basic rebranding of the admin theme, without any structural changes. Shifts the color scheme to blues, gets rid of dark table headers, adds border radius to fields, and other small adjustments.
Related Pull Requests
Builds on #21 for Mage-OS logo and brand changes
Manual testing scenarios (*)
Questions or comments
I am not a designer, and this is an early and relatively small effort, so there is room for improvement. But I think this is an accessible and meaningful improvement over the existing theme, and provides a direction for improvement over time.
There's been discussion of greater improvements (like changing the menu to purely CSS for performance and stability), but in the interest of time I've stuck to minor style changes only at this point. Others are more than welcome to propose further and deeper changes, provided the changes won't cause issues for compatibility.
Screenshots of the work to date:
Contribution checklist (*)